BDMS 350: water level csv feature test update#332
Merged
jacob-a-brown merged 5 commits intoJan 6, 2026
Conversation
measuring_person is the field staff that took the measurement, not a lexicon value
…load This scenario tests that measuring_person in the CSV must match one of the field_staff entries.
jacob-a-brown
requested review from
chasetmartin,
jirhiker,
ksmuczynski and
marissafichera
jirhiker
approved these changes
Jan 5, 2026
chasetmartin
approved these changes
Jan 5, 2026
Contributor
Author
|
@jirhiker and @chasetmartin I made another minor update for review. Since it pertains to the feature file I added it to this PR: In the summary I changed The actual errors/warnings are reported in the payload, the standard out, and the standard error. |
chasetmartin
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
measuring_personis the field staff that took the measurement, not a lexicon valueHow
Implementation summary - the following was changed / added / removed:
measuring_personfrom the scenarioUpload fails due to invalid lexicon valuesmeasuring_persondoes not correspond withfield_staff,field_staff_2, orfield_staff_3Notes
Any special considerations, workarounds, or follow-up work to note?